Move workspace memory-allocation to PyTorch #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RezaYazdaniAminabadi
requested review from
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam,
ShadenSmith and
tjruwase
as code owners
eltonzheng
reviewed
Jan 12, 2021
csrc/includes/context.h
Outdated
| @@ -64,17 +64,18 @@ class Context { | |||
| return _ctx; | |||
| } | |||
|
|
|||
| void GenWorkSpace(size_t size) | |||
| void GenWorkSpace(void* workspace) // (size_t size) | |||
There was a problem hiding this comment.
Rename it to SetWorkSpace()?
There was a problem hiding this comment.
Thanks Elton, will do! :)
csrc/includes/context.h
Outdated
| assert(_workspace == nullptr); | ||
| cudaMalloc(&_workspace, size); | ||
| } else if (_workSpaceSize < size) { | ||
| cudaFree(_workspace); | ||
| cudaMalloc(&_workspace, size); | ||
| } | ||
|
|
||
| _workSpaceSize = size; | ||
| _workSpaceSize = size;*/ |
There was a problem hiding this comment.
_workSpaceSize can be deleted from context class?
There was a problem hiding this comment.
yes agreed!
csrc/includes/context.h
Outdated
| if (!_workspace) { | ||
| if (!workspace) { throw std::runtime_error("Workspace is null."); } | ||
| _workspace = workspace; | ||
| /*if (!_workspace) { |
There was a problem hiding this comment.
remove those commented code if they are useless.
There was a problem hiding this comment.
I have just commented them to verify that this new way is working properly, after some tests I will remove the comments
| _training, | ||
| _gelu_checkpoint)); | ||
|
|
||
| // Context::Instance().GenWorkSpace(get_workspace_size<T>(_batch_size, |
| layer->GetNumHeads(), | ||
| layer->IsTrainingMode(), | ||
| layer->GeluCheckpoint())}, | ||
| options); |
There was a problem hiding this comment.
can we use g_output.options() here instead of creating a new option?
There was a problem hiding this comment.
good point 👍
conglongli
approved these changes
Jan 12, 2021
eltonzheng
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.