ds_report bug fix on cpu and guard torch import in setup.py #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffra
requested review from
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
niumanar,
RezaYazdaniAminabadi,
samyam,
ShadenSmith and
tjruwase
as code owners
jeffra
changed the title
ShadenSmith
approved these changes
Nov 12, 2020
tjruwase
approved these changes
Nov 12, 2020
| @@ -62,6 +62,8 @@ def ninja_installed(): | |||
| def nvcc_version(): | |||
| import torch.utils.cpp_extension | |||
| cuda_home = torch.utils.cpp_extension.CUDA_HOME | |||
| if cuda_home is None: | |||
| return f"{RED} [FAIL] cannot find CUDA_HOME via torch.utils.cpp_extension.CUDA_HOME={torch.utils.cpp_extension.CUDA_HOME} {END}" | |||
There was a problem hiding this comment.
Do we need to guard against torch import error?
There was a problem hiding this comment.
I think this is okay, the torch guard in setup.py is more related to the pip install deepspeed assumes now that torch is installed already. But we won't even install deepspeed at all if torch isn't installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.