supporting different intermediate sizes other than 4 * hidden_dim #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RezaYazdaniAminabadi
requested review from
ShadenSmith,
jeffra and
eltonzheng
RezaYazdaniAminabadi
requested review from
arashashari,
awan-10,
cli99,
conglongli,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
added 2 commits
September 9, 2020 22:19
tjruwase
reviewed
Sep 10, 2020
tests/unit/test_cuda_forward.py
Outdated
| # (8,1536,128,24,3,False,False), | ||
| # (8,1536,128,24,3,False,True), | ||
| # (8,2048,128,32,3,False,False), | ||
| # (8,2048,128,32,3,False,True), |
There was a problem hiding this comment.
I put them back!
tjruwase
approved these changes
Sep 10, 2020
eltonzheng
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had the assumption that the intermediate size is always 4 times hidden_dimension. Now, I make it configurable with having the same intermediate_size as before by default.