Fix issue with corrupted output on long generation for GPT #2344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue described in #2300
Only updating MAX_OUT_TOKES doesn't helps and main issue is in temp_buf that was allocated just after
output
tensorThen in
attention_unfused
T* workspace = (T*)output + bsz * seq_len * heads * k;
where output istemp_buf
fromds_softmax_context
In the result
temp_buf
overlapsquery_cont
allocated inds_softmax_context
I've put
temp_buf
just afterkv_cache
and it helpsMinimal steps to reproduce: