Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap AllowEmptyTelemetry in condition #524

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Wrap AllowEmptyTelemetry in condition #524

merged 1 commit into from
Nov 15, 2024

Conversation

zijchen
Copy link
Member

@zijchen zijchen commented Nov 14, 2024

Fixes #518

This was introduced for dotnet publish support, adding a check for build runtime around it to unblock SSDT.

@zijchen zijchen requested a review from Ri7Sh November 15, 2024 00:41
@zijchen zijchen merged commit 160081d into main Nov 15, 2024
13 checks passed
@zijchen zijchen deleted the zijchen/518 branch November 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llali llali llali approved these changes

@Ri7Sh Ri7Sh Awaiting requested review from Ri7Sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Build.Sql 0.2.4-preview throws error in VS 17.12 and MSBuild, works in dotnet build
2 participants
@zijchen @llali