Add a test for #330

microsoft · Feb 9, 2024 · 3c8fff1 · 3c8fff1
1 parent 0e444d0
commit 3c8fff1
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 2 deletions.
diff --git a/test/Microsoft.Build.Sql.Tests/BuildTests.cs b/test/Microsoft.Build.Sql.Tests/BuildTests.cs
@@ -224,5 +224,45 @@ public void VerifyBuildWithCentralPackageManagement()
             Assert.AreEqual(string.Empty, stdError);
             this.VerifyDacPackage();
         }
+
+        [Test]
+        [TestCase("net46")]
+        [TestCase("net461")]
+        [TestCase("net462")]
+        [TestCase("net47")]
+        [TestCase("net471")]
+        [TestCase("net472")]
+        [TestCase("net48")]
+        [TestCase("net481")]
+        [TestCase("netstandard2.1")]
+        [TestCase("netcoreapp3.1")]
+#if NET5_0_OR_GREATER
+        [TestCase("net5.0")]
+#endif
+#if NET6_0_OR_GREATER
+        [TestCase("net6.0")]
+#endif
+#if NET7_0_OR_GREATER
+        [TestCase("net7.0")]
+#endif
+#if NET8_0_OR_GREATER
+        [TestCase("net8.0")]
+#endif
+        // https://github.com/microsoft/DacFx/issues/330
+        public void VerifyBuildWithDifferentTargetFrameworks(string targetFramework)
+        {
+
+            ProjectUtils.AddProperties(this.GetProjectFilePath(), new Dictionary<string, string>()
+            {
+                { "TargetFramework", targetFramework }
+            });
+
+            int exitCode = this.RunDotnetCommandOnProject("build", out string stdOutput, out string stdError);
+
+            // Verify success
+            Assert.AreEqual(0, exitCode, "Build failed with error " + stdError);
+            Assert.AreEqual(string.Empty, stdError);
+            this.VerifyDacPackage();
+        }
     }
 }
diff --git a/test/Microsoft.Build.Sql.Tests/DotnetTestBase.cs b/test/Microsoft.Build.Sql.Tests/DotnetTestBase.cs
@@ -23,7 +23,7 @@ public abstract class DotnetTestBase
 
         protected string WorkingDirectory
         {
-            get { return Path.Combine(TestContext.CurrentContext.WorkDirectory, TestContext.CurrentContext.Test.Name); }
+            get { return Path.Combine(TestContext.CurrentContext.WorkDirectory, TestUtils.EscapeTestName(TestContext.CurrentContext.Test.Name)); }
         }
 
         protected string CommonTestDataDirectory
@@ -33,7 +33,7 @@ protected string CommonTestDataDirectory
 
         protected string CurrentTestDataDirectory
         {
-            get { return Path.Combine(this.CommonTestDataDirectory, TestContext.CurrentContext.Test.Name); }
+            get { return Path.Combine(this.CommonTestDataDirectory, TestUtils.EscapeTestName(TestContext.CurrentContext.Test.Name)); }
         }
 
         [SetUp]

diff --git a/test/Microsoft.Build.Sql.Tests/TestUtils.cs b/test/Microsoft.Build.Sql.Tests/TestUtils.cs
@@ -72,5 +72,10 @@ public static void CopyDirectoryRecursive(string sourceDirectoryPath, string tar
                 CopyDirectoryRecursive(subDir.FullName, destDirName);
             }
         }
+
+        public static string EscapeTestName(string testName)
+        {
+            return testName.Replace("\"", "_");
+        }
     }
 }