Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix couple build issues related to authoring scenarios #1643

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

manodasanW
Copy link
Member

This PR addresses a couple issues related to authoring scenarios:

  • If an authoring project had project references to other C# projects, those projects got treated as also implementing the winmd of the authoring project which isn't true. Instead, it should be the authoring project dll is the one that implements the winmd and the others are just copied over. This addresses that by no longer looping over all the managed dlls but they are still added for publishing.
  • When an authoring project is consumed by a native project, any managed dependencies are copied over. But if there were multiple references to the same dll due to different versions such as with WinRT.Runtime where a version can come from the nuget reference and the other from the Windows SDK projection, they were not correctly resolved to choose the higher version. We are now using ResolveAssemblyReferences to resolve those issues so that way we do not need to handle them ourselves.
  • Also noticed after the changes that project reference dependencies were not getting copied over, so checking for CopyLocal also while copying them.

Tested with a couple different project reference scenarios to ensure things work as expected.

…ng associated with winmds due to being a dependency of an authoring project and fixing issue where multiples references of the same file are not handled such that the latest is chosen.
@manodasanW manodasanW merged commit d54c715 into master Jun 21, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/authoringtarget branch June 21, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants