Fix .NET Standard authoring support #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an internal team that uses our authoring support with .NET Standard. It looks like our recent AOT changes regressed them as we didn't have the netstandard check for the activation factory scenario. This PR makes sure to check netstandard compat before writing the
WinRTExposedTypeattributes as those are only on .NET 6+ right now. Also doing a minor change to the Windows SDK projection type for how we throw the exception to see if it helps with unblocking an internal team who is running into issues there due to using an older version of .NET until they can get that updated.