-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatiblity with WinUI Preview 4 (using daily) #124
Comments
It looks from the errors I'm seeing from your repro that I need to install some VC SDKs... trying now... |
I never could get the SDKs to work. But I was able to repro the problem trivially in a test so we can make sure this never regresses. |
Thanks @AArnott . Fix looks great |
Just confirming that 0.1.370-beta works great with WinUI 3. Thank you! |
@AArnott FYI if you're hitting this: |
I never hit that, because your repro used earlier build targets. But I installed all the ones referenced in your repro and it still didn't work. |
Looks like I'm still hitting some incompatibilities with WinUI and the latest daily (v0.1.362-beta). From my understanding the issues in #59 should have been addressed already.
To repro, create the following project:
Next add
Shell_NotifyIcon
to theNativeMethods.txt
and compile.Observe these two build errors:
Remove the WinUI package, and things builds fine.
The first one seems to be able to be addressed with changing
internal System.Guid guidItem;
tointernal global::System.Guid guidItem;
which in turn takes care of the second error.I'm guessing anything that is using a namespace in the type name should be prefixed with
global::
The text was updated successfully, but these errors were encountered: