This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add contracts for System.Version #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be safe to also add the following contracts for properties. //for Major and Minor
Contract.Ensures(Contract.Result<int>() >= 0);
//for Build and Revision
Contract.Ensures(Contract.Result<int>() >= -1);
//for MajorRevision and MinorRevision
Contract.Ensures(Contract.Result<short>() >= -1); |
|
Thanks @hubuk. Confirmed still compiling. |
| } | ||
|
|
||
| [Pure] | ||
| public int MajorRevision |
There was a problem hiding this comment.
I haven't spotted this before. Version.MajorRevision is of short type.
There was a problem hiding this comment.
Good catch, I'll fix them up tomorrow morning.
SergeyTeplyakov
added a commit
that referenced
this pull request
Jan 26, 2016
Add contracts for System.Version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-checked with Reference Source.
I've verified that this compiles, and work as expected for .NET 4.5.