This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix warnings showing in the wrong pane in Visual Studio 2015 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sharwell
commented
Jul 22, 2015
sharwell
commented
- Fix Warnings and messages from static contract checking don't appear in the VS2015 error list #137 (easy)
- Fix the build to actually include the results of these changes in the new installers (not easy 😑 )
| @@ -52,7 +52,7 @@ static public String GetLocalRegistryRoot() | |||
| // Get the visual studio root key | |||
| if (VsRoot == null) | |||
| { | |||
| ILocalRegistry2 localReg = GetService(typeof(ILocalRegistry)) as ILocalRegistry2; | |||
| ILocalRegistry2 localReg = GetService(typeof(SLocalRegistry)) as ILocalRegistry2; | |||
There was a problem hiding this comment.
❓ Just curious what was the reason for this switch?
There was a problem hiding this comment.
From the documentation for ILocalRegistry2:
Notes to Callers
Called by any package that wants to register in the Visual Studio section of the registry. This interface is obtained by using theSLocalRegistryservice.
|
Looks good to me! |
|
|
||
| cd Microsoft.VisualStudio.CodeTools\CodeToolsSetup | ||
| call buildMSM release | ||
| call export release |
There was a problem hiding this comment.
💡 It would be better if the return codes from these calls were checked. It's not the only place where this type of check is omitted, but it does cause AppVeyor to report success even if the build fails.
SergeyTeplyakov
added a commit
that referenced
this pull request
Jul 23, 2015
Fix warnings showing in the wrong pane in Visual Studio 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.