Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Update/uninstall leaves VS2013 extension behind #7

Closed
cremor opened this issue Jan 14, 2015 · 16 comments
Closed

Update/uninstall leaves VS2013 extension behind #7

cremor opened this issue Jan 14, 2015 · 16 comments

Comments

@cremor
Copy link

cremor commented Jan 14, 2015

If you uninstall code contracts, either manually or by installing a new version, the VS2013 extension stays installed or stays at the old version. The whole folder C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\Extensions\Microsoft\CodeContracts isn't removed.

@reitzmichnicht
Copy link

I can confirm this.Happens on every update in VS2013.4

@icnocop
Copy link

icnocop commented Apr 9, 2015

This causes VS2013.4 to indicate that there's an update to the Code Contracts for .NET extension even though the latest version is installed.
For example:
Current Version: 1.7.11106.10
New Version: 1.7.11202.10

In this case, there's a directory for both versions in that folder:
C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\Extensions\Microsoft\CodeContracts\1.7.11106.10
C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\Extensions\Microsoft\CodeContracts\1.7.11202.10

For reference, see the following (and its links):
http://stackoverflow.com/questions/27914824/code-contracts-version-does-not-updated

Thank you.

@tom-englert
Copy link
Contributor

This still happens with 1.9.10714.2

@federicoce-moravia
Copy link

Same here. This confuses VS a great deal, misreporting the version number unless you remove the folder(s) and touch the extensions.configurationchanged file.

It may be related, I've noticed the install/repair/uninstall process takes a suspicious amount of time, the progress bar getting stuck at about 80% as if it was wrestling against a file in use or something similar.

@sharwell
Copy link
Member

It may be related, I've noticed the install/repair/uninstall process takes a suspicious amount of time, the progress bar getting stuck at about 80% as if it was wrestling against a file in use or something similar.

This is calls to devenv /setup. Unfortunately not avoidable when you manually install extensions (e.g. use MSI instead of just having the user open a VSIX).

@tom-englert
Copy link
Contributor

Yes, devenv /setup is very slow.
However the installer calls devenv /setup while the old extension is still there. The installer should first remove the old version, then call devenv /setup.

@sharwell
Copy link
Member

@tom-englert Yes that is correct. My comment was only meant to clarify that the "hang" isn't the problem here; failing to remove the extension files is.

sharwell added a commit to sharwell/CodeContracts that referenced this issue Jul 27, 2015
@tom-englert
Copy link
Contributor

@sharwell

This is calls to devenv /setup. Unfortunately not avoidable when you manually install extensions (e.g. use MSI instead of just having the user open a VSIX).

I did not look into details how the extension is installed, but packing the VSIX into the MSI and just call the VsixInstaller.exe as a custom action could simplify the installation, fix issues with left-behind versions and speed up the installation. ❔

@sharwell
Copy link
Member

sharwell commented Aug 1, 2015

@tom-englert Eventually the best possible experience would be an installation that only required VSIX and NuGet. As long as the MSI is used, we'll be fine as long as it properly detects installed versions and knows how to remove itself (both of which should now be in place).

@tom-englert
Copy link
Contributor

@sharwell it was just an idea - however never change a running system 😄

@Angeland
Copy link

Angeland commented Apr 6, 2016

Reopen. This issue is still here. asking for the update in VS after uninstall it still asks. after the vs extensions codecontract folder is removed it STILL asks for update.

@joemey
Copy link

joemey commented May 2, 2016

I too have the problem with the wrong version number and it looks like the problem ist that for VS 2015 the current installer contains a wrong extension.manifest file (V14extension.manifest in the msi package) with the version 1.8.10107.10.
The manifest files for V10, V11, V12 are correct.

@Fabman08
Copy link

@joemey same problem too

@quixoticaxis
Copy link

@joemey same problem with VS2015 Update 2.

@hickford
Copy link

hickford commented Jul 18, 2016

Is this fixed in the strong sense "new versions tidy up the mess left by old versions" or only in the weak sense "new versions don't leave mess of their own"?

I had to follow http://stackoverflow.com/a/27914825/284795 to cleanup Code Contracts on my computer

@thegreatco
Copy link

I had to manually edit the manifest file to update the version listed in VS2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests