Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBFT and forwarding client certificates #971

Merged
merged 4 commits into from
Mar 23, 2020
Merged

PBFT and forwarding client certificates #971

merged 4 commits into from
Mar 23, 2020

Conversation

ashamis
Copy link
Contributor

@ashamis ashamis commented Mar 20, 2020

  • Do not forward the request signatures unless required - with PBFT
  • Forward the signatures for the members frontend

@ashamis ashamis requested a review from a team as a code owner March 20, 2020 16:15
@jumaffre
Copy link
Contributor

As discussed, there's a more general bug here since #962. We should no longer forward the caller certificate uniquely based on which frontend we are executing on but based on whether the handler required client identity too. I'll create an issue for this but it shouldn't block this PR.

@codecov-io
Copy link

Codecov Report

Merging #971 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
- Coverage   68.07%   68.05%   -0.02%     
==========================================
  Files         103      103              
  Lines        8177     8175       -2     
==========================================
- Hits         5566     5563       -3     
- Misses       2611     2612       +1     
Flag Coverage Δ
#unit_BFT ?
#unit_CFT 68.05% <0.00%> (?)
Impacted Files Coverage Δ
src/node/rpc/frontend.h 64.23% <0.00%> (ø)
src/node/rpc/memberfrontend.h 67.46% <ø> (-0.12%) ⬇️
src/ds/ringbuffer.h 92.39% <0.00%> (-0.54%) ⬇️

@ghost
Copy link

ghost commented Mar 20, 2020

less_msg@6263 aka 20200323.45 vs master ewma over 30 builds from 5953 to 6261
images

@ashamis ashamis merged commit 141c680 into microsoft:master Mar 23, 2020
eddyashton pushed a commit to eddyashton/CCF that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants