-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some RPCs are GET-only #966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
Mar 19, 2020
jumaffre
approved these changes
Mar 20, 2020
Looks like there are still some issues with the CI but the changes look good! |
olgavrou
reviewed
Mar 20, 2020
verb_selection@6187 aka 20200323.6 vs master ewma over 30 builds from 5897 to 6181 |
olgavrou
approved these changes
Mar 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 68.06% 68.28% +0.22%
==========================================
Files 103 103
Lines 8177 8234 +57
==========================================
+ Hits 5565 5622 +57
Misses 2612 2612
|
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #633.
This PR:
install(...).set_http_get_only()
, or more generally.restrict_allowed_verbs({HTTP_DELETE, HTTP_GET,...})
getCommit
,listMethods
, etc). Mostly things that areRead
and have simple params typesc.get
rather thanc.rpc
client.do
in Python, removing empty params so we have actually empty bodies rather than JSON nulls)NB: I'm using "verb" to describe GET, POST etc. These are generally referred to as methods, but we already have a lot of code using
method
to describe the RPC-identifier. This is a bit clumsy - maybe we should do a renaming pass to make the oldmethod
a resource, and then we can usemethod
instead ofverb
? Opinions welcome.