Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pid file #927

Merged
merged 19 commits into from
Mar 6, 2020
Merged

Pid file #927

merged 19 commits into from
Mar 6, 2020

Conversation

achamayou
Copy link
Member

fix #522

@achamayou achamayou requested a review from a team as a code owner March 6, 2020 11:25
eddyashton
eddyashton approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@eddyashton eddyashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently get the pid in remote.py (line 258) by grepping ps. Can we retrieve this file instead?

@achamayou
Copy link
Member Author

@eddyashton yes!

@codecov-io
Copy link

codecov-io commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #927 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   69.13%   69.12%   -0.01%     
==========================================
  Files         100      100              
  Lines        7769     7770       +1     
==========================================
  Hits         5371     5371              
- Misses       2398     2399       +1
Flag Coverage Δ
#unit_BFT 69.11% <0%> (-0.02%) ⬇️
#unit_CFT 69.12% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/ds/files.h 39.29% <0%> (-1.46%) ⬇️

@ghost
Copy link

ghost commented Mar 6, 2020 •
edited by ghost
Loading

pid_file@5768 aka 20200306.10 vs master ewma over 30 builds from 5400 to 5763
images

@achamayou achamayou merged commit ed6c495 into microsoft:master Mar 6, 2020
eddyashton pushed a commit to eddyashton/CCF that referenced this pull request Mar 24, 2020
@achamayou
Pid file (microsoft#927)
a6698f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgavrou olgavrou olgavrou approved these changes

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CCF node to write its pid to file
4 participants
@achamayou @codecov-io @eddyashton @olgavrou