Cannot trust or retire a retired node #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cannot_trust_retire_node@4562 aka 20200205.4 vs master ewma over 30 builds from 4183 to 4560 |
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
- Coverage 77.38% 74.36% -3.02%
==========================================
Files 150 125 -25
Lines 11578 10273 -1305
==========================================
- Hits 8959 7639 -1320
- Misses 2619 2634 +15
|
olgavrou
reviewed
Feb 5, 2020
| @@ -32,7 +32,6 @@ namespace ccf | |||
| Tables::MEMBER_CERTS, | |||
There was a problem hiding this comment.
Members should have access to the nodes table via lua, same as they do to the members table, etc. If they want to change the way that the nodes are handled they should be able to propose and vote for that.
There was a problem hiding this comment.
The join protocol is implemented in C++ though, and we do want to enforce a particular set of conditions and transitions for nodes to preserve security guarantees. What's the use case for opening this up completely?
achamayou
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #778
It should not be possible to trust a node that is already retired. Also, the
ccf.nodestables should not be writable from Lua - we really want to limit what members can change in that table (i.e. only trust and retire nodes, via C++ functions).