Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sphinx docs #759

Merged
merged 13 commits into from
Jan 30, 2020
Merged

Conversation

eddyashton
Copy link
Member

Updating docs to describe current state, in particular HTTP-by-default. Replacing all ./client and ./memberclient sample commands with curl equivalents. Have removed some since I think we're repeating ourselves (don't need to show a sample vote for every proposal).

Most of these edits were done by hand and untested, so please read carefully for dumb mistakes. Doing raw proposals by hand in curl rather than by memberclient is still a little awkward (in particular things like "turn this binary file into a JSON array and put that in the correct field of this JSON object") - this should be mitigated once we support non-JSON-RPC payloads.

Opening as a draft for early review while I rewrite the remaining sections.

@eddyashton eddyashton marked this pull request as ready for review January 30, 2020 15:20
@eddyashton eddyashton requested a review from a team as a code owner January 30, 2020 15:20
@eddyashton eddyashton merged commit 26a60ad into microsoft:master Jan 30, 2020
@eddyashton eddyashton deleted the docs_http_samples branch January 30, 2020 16:53
eddyashton added a commit to eddyashton/CCF that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants