Address issue with embedded certificates in JWT x5c #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
changed the title
achamayou
added
auto-backport
maxtropets
reviewed
Aug 15, 2024
Co-authored-by: Max <[email protected]>
maxtropets
reviewed
Aug 15, 2024
maxtropets
approved these changes
Aug 15, 2024
maxtropets
approved these changes
Aug 15, 2024
ghost
pushed a commit
that referenced
this pull request
Aug 15, 2024
Co-authored-by: Max <[email protected]> (cherry picked from commit 4bb3c1e)
ghost
mentioned this pull request
achamayou
pushed a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the way the Verifier_OpenSSL::Verifier_OpenSSL handles being constructed from either a DER or a PEM.
The code initially tries to construct and X509 type with
Unique_X509(certbio, true /* pem */)before retrying withUnique_X509(certbio, false /* pem */)in case the value is DER.Unique_X509()callsPEM_read_bio_X509()internally, which ignores all input prior to-----BEGIN CERTIFICATE-----, and parses from there.If a certificate embeds other certificates, and is provided in DER form, this results in mis-parsing as the nested certificate.
Longer term, we should avoid calls that take
DER|PEMand have a static distinction. For the time being, this adds a validation check to the content before handing it toPEM_read_bio_X509().