More informative error messages for invalid txids

[achamayou]

Before:

curl -k
https://127.0.0.1:8000/node/tx?transaction_id=0.0
{"error":{"code":"InternalError","message":"Error code: InternalError"}}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=1.1
{"status":"Invalid","transaction_id":"1.1"}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=1.0
{"error":{"code":"InternalError","message":"Error code: InternalError"}}

$ curl -k https://127.0.0.1:8000/app/tx?transaction_id=0.1
{"status":"Invalid","transaction_id":"0.1"}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=2.0
{"error":{"code":"InternalError","message":"Error code: InternalError"}}

After:

curl -k https://127.0.0.1:8000/app/tx?transaction_id=0.0
{"error":{"code":"InvalidQueryParameterValue","message":"The value '0.0' passed as query parameter 'transaction_id' could not be converted to a valid Transaction ID."}}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=1.1
{"status":"Invalid","transaction_id":"1.1"}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=1.0
{"error":{"code":"InvalidQueryParameterValue","message":"The value '1.0' passed as query parameter 'transaction_id' could not be converted to a valid Transaction ID."}}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=0.1
{"error":{"code":"InvalidQueryParameterValue","message":"The value '0.1' passed as query parameter 'transaction_id' could not be converted to a valid Transaction ID."}}

curl -k https://127.0.0.1:8000/app/tx?transaction_id=2.0
{"error":{"code":"InvalidQueryParameterValue","message":"The value '2.0' passed as query parameter 'transaction_id' could not be converted to a valid Transaction ID."}}

[achamayou]

I wonder if it is worth preserving "Invalid" for 0.1 and 1.1, i.e. you can always ask about the first transaction, even for views that we never use. Edit: I think we should do that in fact, there may be users who have a flow similar to what the historical test did and depend on this.

[lemmy]

@marina-p fuzzed CCF with https://github.com/microsoft/restler-fuzzer and found the following:

FuzzLean found 1 bug: 

2024-07-18 10:00:07.393: Sending: 'GET /app/log/public/historical/range?from_seqno=1&to_seqno=0963012895303452&id=1 HTTP/1.1\r\nAccept: application/json\r\nHost: 20.14.79.29\r\nContent-Length: 0\r\nUser-Agent: restler/9.2.4\r\nx-restler-sequence-id: 902dc766-095a-4b18-a5f5-09356ac1b102\r\n\r\n'

2024-07-18 10:00:07.477: Received: 'HTTP/1.1 500 INTERNAL_SERVER_ERROR\r\ncontent-length: 75\r\ncontent-type: application/json\r\n\r\n{"error":{"code":"InternalError","message":"Unable to retrieve Tx status"}}'

[achamayou]

@lemmy as @eddyashton pointed out (and resolved in #6401), I was confused, and despite superficial similarity this is actually a different issue with the logging app itself.