New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Historical queries cache size soft limit #6282

Merged

maxtropets merged 12 commits into microsoft:main from maxtropets:f/3234-historical-states-cache-size-limit

Jul 1, 2024

Collaborator

maxtropets commented Jun 20, 2024 •

edited by achamayou

Loading

Closes #3234

maxtropets force-pushed the f/3234-historical-states-cache-size-limit branch 10 times, most recently from d3fe50f to 3f44243 Compare

June 26, 2024 15:03

maxtropets marked this pull request as ready for review

June 26, 2024 15:04

maxtropets requested a review from a team

June 26, 2024 15:04

maxtropets changed the title ~~[Draft] [WIP] Historical: cache size soft limit~~ Historical: cache size soft limit

maxtropets changed the title ~~Historical: cache size soft limit~~ Historical queries cache size soft limit

maxtropets force-pushed the f/3234-historical-states-cache-size-limit branch from 3f44243 to 6e55275 Compare

June 26, 2024 18:39

achamayou reviewed

View reviewed changes

include/ccf/historical_queries_interface.h Outdated Show resolved Hide resolved

achamayou reviewed

View reviewed changes

samples/apps/logging/logging.cpp Outdated Show resolved Hide resolved

achamayou reviewed

View reviewed changes

samples/apps/logging/logging.cpp Outdated Show resolved Hide resolved

achamayou reviewed

View reviewed changes

src/node/historical_queries.h Outdated Show resolved Hide resolved

achamayou reviewed

View reviewed changes

src/node/historical_queries.h Outdated Show resolved Hide resolved

achamayou reviewed

View reviewed changes

src/node/test/historical_queries.cpp Outdated Show resolved Hide resolved

achamayou reviewed

View reviewed changes

src/node/test/historical_queries.cpp Outdated Show resolved Hide resolved

achamayou approved these changes

View reviewed changes

maxtropets mentioned this pull request

Dynamically configure historical cache limit in logging app #6299

Closed

maxtropets and others added 6 commits

June 27, 2024 16:18


          Historical cache auto-shrink

732e7bf


          Better tests


          Update include/ccf/historical_queries_interface.h

c576d23

Co-authored-by: Amaury Chamayou <[email protected]>


          Update samples/apps/logging/logging.cpp

bc9011d

Co-authored-by: Amaury Chamayou <[email protected]>


          Update src/node/test/historical_queries.cpp

41b4de1

Co-authored-by: Amaury Chamayou <[email protected]>


          Update src/node/test/historical_queries.cpp

003c934

Co-authored-by: Amaury Chamayou <[email protected]>

maxtropets and others added 3 commits

June 27, 2024 16:18


          Update src/node/historical_queries.h

83f186a

Co-authored-by: Amaury Chamayou <[email protected]>


          CR minor cleanup

c613d1c


          Poke

30e9734

maxtropets force-pushed the f/3234-historical-states-cache-size-limit branch from b6a0cad to 30e9734 Compare

June 27, 2024 16:18

eddyashton approved these changes

View reviewed changes

achamayou and others added 2 commits

June 28, 2024 09:18


          Merge branch 'main' into f/3234-historical-states-cache-size-limit

1db8c5f


          Merge branch 'main' into f/3234-historical-states-cache-size-limit

bb596a7

maxtropets enabled auto-merge (squash)

July 1, 2024 16:11


          Merge branch 'main' into f/3234-historical-states-cache-size-limit

8db27ad

maxtropets merged commit 4a4252c into microsoft:main

25 of 28 checks passed

achamayou mentioned this pull request

Improve historical query cache microsoft/scitt-ccf-ledger#83

Open

maxtropets self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet