Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method that decodes path parameters #4126

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Add a method that decodes path parameters #4126

merged 2 commits into from
Aug 15, 2022

Conversation

MahatiC
Copy link
Member

@MahatiC MahatiC commented Aug 15, 2022 •
edited
Loading

Resolves #4112

@MahatiC MahatiC requested a review from a team August 15, 2022 08:05
@MahatiC MahatiC marked this pull request as draft August 15, 2022 08:05
@MahatiC
Copy link
Member Author

MahatiC commented Aug 15, 2022

Would like to take a second look at this, so marked it as draft. But comments are welcome.

@ghost
Copy link

ghost commented Aug 15, 2022 •
edited by ghost
Loading

decoded-path-params@48587 aka 20220815.14 vs main ewma over 20 builds from 48348 to 48583

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
48348 20220804.16 6470.12 8.40213e+07 20162.3 1.63882e+07 5611.59 1.56017e+07 2610.84 1.00967e+07 1603.88 1.66859e+08 2133.3 9.31027e+06 1408.7 9.87014e+07 1936.8 9.04813e+06 20767.6 874353 1.31602e+06 8.95888e+06 3.50685e+07
48375 20220805.3 6581.93 8.40213e+07 20244.8 1.58639e+07 5588.85 1.53396e+07 2598.55 1.00967e+07 1590.43 1.66335e+08 2110.71 9.31027e+06 1437.79 9.79149e+07 1965.96 9.04813e+06 20769.3 901323 1.3709e+06 9.34298e+06 3.58669e+07
48376 20220805.4 6575.88 8.40213e+07 20602.8 1.58639e+07 5680.24 1.53396e+07 2480.28 1.00967e+07 1649.69 1.66859e+08 2122.21 9.31027e+06 1442.64 9.81771e+07 1929.88 9.04813e+06 20495.5 911473 1.37026e+06 9.41172e+06 3.63121e+07
48391 20220805.11 6446.79 8.32349e+07 20014.6 1.6126e+07 5628.3 1.58639e+07 2594.33 1.00967e+07 1603.05 1.66597e+08 2073.94 9.31027e+06 1415.05 9.63421e+07 1920.2 9.04813e+06 18389.9 909972 1.37044e+06 9.18377e+06 3.59298e+07
48399 20220808.2 6499.33 8.42835e+07 20415.4 1.66503e+07 5670.06 1.53396e+07 2554.96 1.00967e+07 1630.43 1.645e+08 2118.44 9.31027e+06 1412.02 9.81771e+07 1932.81 9.04813e+06 20513.5 871966 1.36106e+06 9.20859e+06 3.56168e+07
48407 20220808.5 6438.4 8.40213e+07 20249.2 1.6126e+07 5638.84 1.53396e+07 2548 1.00967e+07 1595.51 1.67121e+08 2108.24 9.31027e+06 1430.87 9.81771e+07 1927.33 8.78598e+06 19704.5 888306 1.36669e+06 9.19206e+06 3.58669e+07
48422 20220808.12 6398.02 8.3497e+07 20137.7 1.63882e+07 5695.03 1.53396e+07 2625.18 9.83456e+06 1582.61 1.66859e+08 2120.63 8.78598e+06 1404 9.73907e+07 1935.04 9.04813e+06 19485.4 902483 1.39112e+06 9.26278e+06 3.59298e+07
48427 20220808.14 6230.03 8.40213e+07 19679.8 1.58639e+07 5547.25 1.53396e+07 2417.7 1.03588e+07 1550.66 1.645e+08 2072.83 9.04813e+06 1369.48 9.76528e+07 1959.08 9.04813e+06 17632.4 920524 1.40023e+06 9.3901e+06 3.63114e+07
48435 20220808.17 6396.62 8.37592e+07 20212.4 1.58639e+07 5676.31 1.56017e+07 2492.05 1.00967e+07 1582.1 1.66859e+08 2084.38 9.31027e+06 1401.8 9.79149e+07 1936.03 9.04813e+06 22698 907599 1.38341e+06 9.30486e+06 3.55556e+07
48452 20220809.2 6397.96 8.37592e+07 20177.9 1.63882e+07 5695.08 1.56017e+07 2498.61 1.00967e+07 1602.55 1.66597e+08 2093.11 9.31027e+06 1399.63 9.81771e+07 1931.37 8.78598e+06 20235.1 903311 1.37495e+06 9.21688e+06 3.54939e+07
48461 20220809.7 6585.9 8.3497e+07 20158 1.63882e+07 5669.79 1.53396e+07 2557.5 1.00967e+07 1626.24 1.645e+08 2121.12 9.31027e+06 1443.42 9.84392e+07 1986.42 9.04813e+06 18271.3 886722 1.41396e+06 9.41163e+06 3.59292e+07
48466 20220809.9 6444.69 8.37592e+07 20005.2 1.56017e+07 5605.49 1.56017e+07 2541.33 1.00967e+07 1618.96 1.66859e+08 2115.35 9.31027e+06 1450.97 9.81771e+07 2014.27 9.04813e+06 20835.2 901011 1.37201e+06 9.22938e+06 3.58669e+07
48469 20220810.1 6186.62 8.42835e+07 20033.2 1.58639e+07 5604.55 1.53396e+07 2556.71 9.83456e+06 1587.94 1.64762e+08 2082.75 9.04813e+06 1421.15 9.84392e+07 1944.56 9.04813e+06 22527.5 906189 1.38172e+06 9.21684e+06 3.58669e+07
48486 20220811.1 6270.83 8.40213e+07 19935.8 1.58639e+07 5612.96 1.53396e+07 2499.35 1.2456e+07 1583.15 1.66859e+08 2112.67 9.31027e+06 1405.59 9.81771e+07 1923.87 9.04813e+06 23657.6 917679 1.38602e+06 9.28794e+06 3.56788e+07
48499 20220811.7 6318.24 8.45456e+07 20081.4 1.66503e+07 5615.16 1.53396e+07 2595.81 1.00967e+07 1589.3 1.66072e+08 2084.45 9.31027e+06 1416.86 9.84392e+07 1942.12 1.11453e+07 17960.4 888152 1.37708e+06 9.23767e+06 3.56788e+07
48519 20220812.3 6254.67 8.29727e+07 20234.9 1.69124e+07 5607.59 1.56017e+07 2489.25 1.00967e+07 1591.82 1.66597e+08 2123.82 9.04813e+06 1429.55 9.81771e+07 1935.56 9.04813e+06 20089.9 898322 1.37302e+06 9.23771e+06 3.58042e+07
48526 20220812.7 6074.64 8.42835e+07 19544.3 1.66503e+07 5648.38 1.50774e+07 2609.43 1.00967e+07 1612.39 1.645e+08 2111.9 9.57242e+06 1440.93 9.66042e+07 2018.87 8.78598e+06 18707.2 921975 1.33881e+06 9.33021e+06 3.47113e+07
48562 20220815.2 6242.99 8.42835e+07 19715.5 1.63882e+07 5635.6 1.53396e+07 2482.55 1.32424e+07 1574.14 1.66597e+08 2066.59 9.04813e+06 1406.98 9.81771e+07 1916.87 9.04813e+06 19707.5 909447 1.35619e+06 9.20028e+06 3.56168e+07
48572 20220815.8 6341.7 8.48077e+07 19763.8 1.66503e+07 5496.3 1.53396e+07 2501.6 9.83456e+06 1570.93 1.66597e+08 2107.98 9.31027e+06 1423.48 9.87014e+07 1919.72 8.78598e+06 17907.1 901165 1.3418e+06 9.10214e+06 3.59292e+07
48583 20220815.13 6332.98 8.40213e+07 19911.4 1.66503e+07 5538.12 1.53396e+07 2546.68 9.83456e+06 1586.74 1.645e+08 2108.78 9.04813e+06 1406.45 9.81771e+07 1926.97 9.04813e+06 19969.9 871522 1.37035e+06 9.28794e+06 3.56174e+07

decoded-path-params

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
48567 20220815.5 6503.9 8.3497e+07 19874 1.66503e+07 5554.02 1.50774e+07 2534.98 1.00967e+07 1611.83 1.66859e+08 2118.47 9.31027e+06 1432.54 9.81771e+07 2029.07 8.78598e+06 19404.3 899859 1.36614e+06 9.22103e+06 3.56174e+07
48569 20220815.6 6287.6 8.37592e+07 20237.6 1.6126e+07 5600.48 1.53396e+07 2497.47 1.00967e+07 1606.6 1.66597e+08 2070.86 9.31027e+06 1413.5 9.81771e+07 1930.44 1.11453e+07 17830.9 894046 1.38443e+06 9.02596e+06 3.50685e+07
48571 20220815.7 6422.29 8.3497e+07 20160.8 1.6126e+07 5573.59 1.50774e+07 2533.95 1.00967e+07 1617.2 1.66859e+08 2108.82 9.31027e+06 1430.42 9.87014e+07 1927.51 9.04813e+06 18041.9 873189 1.3579e+06 9.2879e+06 3.48887e+07
48582 20220815.12 6333.06 8.40213e+07 20023.5 1.6126e+07 5713.36 1.53396e+07 2541.79 1.00967e+07 1577.61 1.66335e+08 2076.06 9.04813e+06 1397.49 9.76528e+07 1924.84 9.04813e+06 18705.7 899099 1.37153e+06 9.32588e+06 3.55549e+07
48587 20220815.14 6216.03 8.37592e+07 19935.3 1.58639e+07 5613.8 1.56017e+07 2539.61 1.16696e+07 1599.97 1.66597e+08 2109.32 9.04813e+06 1397.45 9.81771e+07 1933.72 9.04813e+06 21779.9 903746 1.37568e+06 9.23346e+06 3.58669e+07

images

@MahatiC MahatiC force-pushed the decoded-path-params branch 2 times, most recently from d5db276 to 64daffe Compare August 15, 2022 09:06
@MahatiC MahatiC marked this pull request as ready for review August 15, 2022 09:08
@MahatiC MahatiC requested a review from achamayou August 15, 2022 09:08
achamayou
achamayou approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@achamayou achamayou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but since this is a user-facing change could you please update the changelog?

@achamayou achamayou added 2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch labels Aug 15, 2022
@MahatiC MahatiC enabled auto-merge (squash) August 15, 2022 12:56
@MahatiC MahatiC merged commit 856df5b into microsoft:main Aug 15, 2022
@github-actions
Copy link

💔 All backports failed

Status Branch Result
❌ release/2.x Backport failed because of merge conflicts

You might need to backport the following PRs to release/2.x:
- Deprecate old logging macros from application code (#4039)
- Add support for tagged loggers and app-specific logging macros (#4024)

Manual backport

To create the backport manually run:

backport --pr 4126

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MahatiC MahatiC deleted the decoded-path-params branch August 15, 2022 13:23
@MahatiC
Copy link
Member Author

MahatiC commented Aug 15, 2022

💔 All backports failed

Status Branch Result
❌ release/2.x Conflict resolution was aborted by the user

Manual backport

To create the backport manually run:

backport --pr 4126

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@MahatiC
Copy link
Member Author

MahatiC commented Aug 15, 2022

💔 All backports failed

Status Branch Result
❌ release/2.x Conflict resolution was aborted by the user

Manual backport

To create the backport manually run:

backport --pr 4126

Questions ?

Please refer to the Backport tool documentation

MahatiC added a commit to MahatiC/CCF that referenced this pull request Aug 15, 2022
@MahatiC
Add a method that decodes path parameters (microsoft#4126)
688d6fc 
(cherry picked from commit 856df5b)

# Conflicts:
#	CHANGELOG.md
@MahatiC MahatiC mentioned this pull request Aug 15, 2022
Merged
@MahatiC MahatiC added the backported This PR was successfully backported to LTS branch label Aug 15, 2022
achamayou pushed a commit to achamayou/CCF that referenced this pull request Aug 16, 2022
@MahatiC
[release/2.x] Cherry pick: Add a method that decodes path parameters (m…
e5d5768 
…icrosoft#4126) (microsoft#4129)

* Add a method that decodes path parameters (microsoft#4126)

(cherry picked from commit 856df5b)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting decoded request path parameter
2 participants
@MahatiC @achamayou