Add experimental support for HTTP/2 #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
wintersteiger
approved these changes
Jul 12, 2022
Co-authored-by: Christoph M. Wintersteiger <[email protected]>
achamayou
reviewed
Jul 13, 2022
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
achamayou
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3342
Now ready for review. Thanks @wintersteiger for fixing the memory leaks!
This PR adds experimental support for client requests over HTTP/2, which will eventually allow developers to build gRPC applications. The support is very much experimental for now but we have parity with most tests run in the
e2e_loggingend-to-end test (except a few tests that test request forwarding, excluded via theno_http2()decorator).The
nghttp2library now always gets included in the enclave application and a single RPC interface always creates HTTP/2 endpoints if theapp_protocolconfiguration entry is set toHTTP2(default isHTTP1).Of course, there's still plenty to do to support HTTP/2 as a first-class protocol (see #3342 for follow-up work) but this PR should have just enough that we can merge this into
main.