-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create temporary ledger chunks while recovery is in progress #3563
Merged
jumaffre
merged 44 commits into
microsoft:main
from
jumaffre:recovery_temporary_ledger_chunks
Feb 22, 2022
Merged
Create temporary ledger chunks while recovery is in progress #3563
jumaffre
merged 44 commits into
microsoft:main
from
jumaffre:recovery_temporary_ledger_chunks
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recovery_temporary_ledger_chunks@42264 aka 20220222.6 vs main ewma over 20 builds from 41879 to 42256 Click to see tablemain
recovery_temporary_ledger_chunks
|
jumaffre
commented
Feb 17, 2022
jumaffre
commented
Feb 17, 2022
jumaffre
commented
Feb 17, 2022
…e/CCF into recovery_temporary_ledger_chunks
wintersteiger
approved these changes
Feb 21, 2022
achamayou
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1652
This PR introduces temporary the
.recovery
suffix for ledger chunks created while the recovery is in progress. These.recovery
files are ignored by subsequent nodes on start-up, which means that a recovery can now be automatically performed after a previous attempt failed.This done by:
.recovery
from the point the historical ledger is truncated (i.e. start of recovery) until the last recovery share is submitted..recovery.
can of course be committed while the recovery is in progress, i.e.ledger_x-y.committed.recovery
..recovery
suffix is removed from all recovery ledger chunks..recovery
ledger files on startup. In other words, they ignore previously failed recovery attempts and re-initiate a recovery as if the failed recovery never happened.How is this tested?
ledger.cpp
TODO:
ledger_open
call without argument