Forum sample rework #2455
Merged
Forum sample rework #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
letmaik/forum-unit-tests@23456 aka 20210414.15 vs main ewma over 20 builds from 23079 to 23450 Click to see table
|
achamayou
approved these changes
Apr 12, 2021
|
CI failure is unrelated. |
beejones
reviewed
Apr 14, 2021
| @@ -41,10 +41,13 @@ The sample app has the following folder layout: | |||
| │ │ └── site.ts | |||
| │ ├── models | |||
| │ │ └── poll.ts | |||
| │ ├── services | |||
There was a problem hiding this comment.
Are CCF/enclave apps called services? If not, I would suggest to change services into e.g. enclaveApp. Services is confusing.
There was a problem hiding this comment.
This term comes from tsoa's docs: https://tsoa-community.github.io/docs/getting-started.html#defining-our-first-model. I've seen this before outside tsoa, another term would be *Manager but I'd like to stick to tsoa's docs here. The whole npm app runs inside CCF, not just the services.
beejones
reviewed
Apr 14, 2021
|
|
||
| Generate opinions, user identities and submit: |
There was a problem hiding this comment.
These edits are really a great addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccf-apppolyfills.esmdependency in favour of native ESM support in Node.js.demo/submit-opinions.tswhich isn't tested in CI and missed a fix that was already applied to the unit tests earlier.selfsigneddependency in favour of usingnode-forgedirectly.tsoaversion and remove redundant (empty) entry script.