Add documentation and test for new oeverify tool #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
commented
Oct 14, 2020
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ curl https://<ccf-node-address>/node/quote --cacert networkcert.pem | jq .quotes[0].raw | xxd -r -p > ccf_node_quote.bin | ||
| $ curl https://<ccf-node-address>/node/quote --cacert networkcert.pem | jq .raw | xxd -r -p > ccf_node_quote.bin |
There was a problem hiding this comment.
General question here: Do we want to still refer to CCF node's quotes as "quotes" (SGX terminology) or Open Enclave's more generic "evidences"?
There was a problem hiding this comment.
Let's stick with quote for now, there's enough renaming going on at the moment, and there's no short term prospect of using anything other than SGX.
jumaffre
commented
Oct 14, 2020
|
verify_quote_test@14306 aka 20201014.41 vs master ewma over 50 builds from 13691 to 14303 |
added 2 commits
October 14, 2020 17:59
achamayou
reviewed
Oct 14, 2020
achamayou
reviewed
Oct 14, 2020
| ## [0.12.1] | ||
| ### Changed | ||
| - Release tarball replaced by a .deb | ||
|
|
||
| ### Fixed | ||
| - Fix LVI build for applications using CCF (#1466) | ||
|
|
There was a problem hiding this comment.
I would prefer we avoid reformatting unless we have an automatic formatter, such as markdownlint.
There was a problem hiding this comment.
https://github.com/DavidAnson/markdownlint looks like a plausible choice.
achamayou
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Open Enclave's
host_verifyhas been replaced withoeverify(0.12-rc1 release), I've updated the documentation and added a new test to verify node's quote with this tool.Note that
/node/quoteused to return an array of one quote. I've changed this slightly so that it returns the quote info directly (slightly easier to parse).