Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HotFix Merkle tree deserialization bug #1363

Merged
merged 3 commits into from
Jul 1, 2020
Merged

HotFix Merkle tree deserialization bug #1363

merged 3 commits into from
Jul 1, 2020

Conversation

ashamis
Copy link
Contributor

@ashamis ashamis commented Jun 30, 2020 •
edited
Loading

This is a hotfix that will be properly resolved by #1362

This fixes the issue where we see:

  1. Serialize the Merkle tree
  2. deserialize the Merkle tree
  3. append to the Merkle tree
    ==> At this point we would see a memory violation.

Thanks to @wintersteiger for the hotfix

@ashamis ashamis requested a review from a team as a code owner June 30, 2020 18:41
@ghost
Copy link

ghost commented Jul 1, 2020 •
edited by ghost
Loading

merkle_tree_bug_fix@10208 aka 20200701.12 vs master ewma over 50 builds from 9671 to 10203
images

@achamayou
Copy link
Member

Thank you @wintersteiger!

@ashamis ashamis merged commit ffdb7d5 into master Jul 1, 2020
@ashamis ashamis deleted the merkle_tree_bug_fix branch July 1, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashamis @achamayou @eddyashton