-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key shares and consortium update #1032
Merged
jumaffre
merged 16 commits into
microsoft:master
from
jumaffre:new_share_consortium_update
Apr 6, 2020
Merged
Key shares and consortium update #1032
jumaffre
merged 16 commits into
microsoft:master
from
jumaffre:new_share_consortium_update
Apr 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
commented
Apr 3, 2020
jumaffre
commented
Apr 3, 2020
new_share_consortium_update@7049 aka 20200406.30 vs master ewma over 50 builds from 6259 to 7022 |
Looks like I shouldn't have deleted one of the |
achamayou
reviewed
Apr 6, 2020
achamayou
reviewed
Apr 6, 2020
achamayou
reviewed
Apr 6, 2020
achamayou
reviewed
Apr 6, 2020
achamayou
reviewed
Apr 6, 2020
achamayou
approved these changes
Apr 6, 2020
… into new_share_consortium_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves items 10 and 14 in #51
Apologies for the large PR: in hindsight, some of the following items could have been committed independently.
This PR:
recovery_threshold
value. This value indicates how many recovery shares are required to re-store the ledger secrets on recovery. Therecovery_threshold
can be set when the first node starts (--recovery-threshold
parameter tocchost
- defaults to the number of original members) or updated via the newset_recovery_threshold
governance command.ack
RPC), they are allocated a recovery share (+ all the shares are reshuffled) and b) when a active member is retired, all the shares are reshuffled.recovery_threshold
> number of active members.Consortium
class was split (see newMember
class) and a newProposal
class was created.Member
s canpropose()
(returns aProposal
),vote()
,ack()
,getEncryptedRecoveryShare()
,submitRecoveryShare()
, etc. while theConsortium
orchestrates members, keeping track of who is active and canvote_using_majority()
.memberclient.py
to test for membership and recovery threshold updates.Still to do: