-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: use grid for sendbox layout #5136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove drop-zone from the grid - Add example layouts into tests - Fix double spacing for attachments
OEvgeny
changed the title
Use grid template for sendbox layout
Use grid for sendbox layout
Apr 17, 2024
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
April 17, 2024 01:16
OEvgeny
changed the title
Use grid for sendbox layout
Fluent: use grid for sendbox layout
Apr 17, 2024
compulim
reviewed
Apr 17, 2024
compulim
approved these changes
Apr 17, 2024
This was referenced Aug 1, 2024
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 7, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgenyDescription
The PR enables advanced layout for the experimental Fluent send box experience, also fixing some small issues found along the way.
Design
We now use named areas to manipulate the positioning for
telephone-keypad
,text-area
,attachment
andcontrols
. These areas can then be remapped using CSS to achieve different layouting options.To avoid double gaps we conditionally add the
attachment
area only when the corresponding to the area class is present.Specific Changes
Send
button when telephone keypad is shownCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)z-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)