Focus on the close button of keyboard help screen #4479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
When TAB into Web Chat, it will show the keyboard help screen.
The focus should be on the close button of the keyboard help screen, instead of on the
role="dialog"
itself.Also updated one of the strings in the keyboard help screen.
Design
Specific Changes
role="dialog"
: removetabIndex="0"
so it will no longer be tabbabletabIndex="-1"
so it will be tabbableoutline: 0
as we already styled a focus ringrole="dialog"
to the close buttonbent
into ES5 as it currently broke IE11,bent
is used by Cognitive Services Speech SDKfocusable={false}
to<svg>
tabIndex={-1}
don't workCHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)