Update files
field in package.json
#4318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
/dist
,/lib
, and/src
folders/dist
was missed from our NPM packagesChanged
package.json
to allowlist/dist
,/lib
,/src
, by @compulim in PR #4318Description
Today, we didn't specify
files
field in ourpackage.json
.However, we found that
npm pack
does not pack the/dist
folder. It does pack/lib
,/src
and most files at the root.Tomorrow, we are specifying
files
to include/dist
,/lib
,/src
folders.Design
We want to allow our web developers to try out our development build directly from our
botframework-webchat
package. However, without/dist
folder packed, our web developers can only try out NPM package, but not bundle.We are allowlisting:
/dist
for bundles/lib
which exports*.js
,*.d.ts
,*.d.ts.map
/src
which are referenced by source map at/lib/**/*.d.ts.map
Specific Changes
package.json
for the following packagesapi
,bundle
,component
,core
, anddirectlinespeech
CHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)