Updated Dockerfile
to support securing container supply chain
#4303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
Dockerfile
to support secure container supply chain, by @compulim in PR #4303Description
Updated our
Dockerfile
with newARG
which can be configured via--build-arg
:ARG
REGISTRY
BASE_IMAGE
docker.io
BASE_IMAGE
$REGISTRY/node:18
(for samples)$REGISTRY/node:18-alpine
(for tooling)Note: all of our images are based on
node
.Design
When developing/testing/building Web Chat, this feature will help our customers to specify a different container registry, or a different base image to start with.
They can specify build arguments when building the image using Docker:
Or via Compose:
Specific Changes
Dockerfile*
with unified build arguments for retargeting base images__tests__/video.js
with slightly changed channel iconCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedTests reviewed (coverage, legitimacy)