Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIGH] Bumping to 4.14.2-0 #4048

Merged
merged 1 commit into from
Sep 20, 2021
Merged

[HIGH] Bumping to 4.14.2-0 #4048

merged 1 commit into from
Sep 20, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 8, 2021

Description

After release of 4.14.1, we are bumping to 4.14.2-0.

Design

Specific Changes

  • Update package.json and package-lock.json for 4.14.2-0
  • Adding 4.14.1 to servicingPlan.json
    • It will be up to services team to enable it
  • Update all samples to use [email protected]
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@cwhitten
Copy link
Member

@compulim I'm curious why this is adding 13k LOC

@compulim
Copy link
Contributor Author

@compulim I'm curious why this is adding 13k LOC

All package-lock.json in this PR are for samples. They were pointing to 4.14.0 and now 4.14.1.

In 4.14.0 -> 4.14.1, we did a lot of package bumps (for security vulnerabilities). That's why we have so many changes in samples/.../package-lock.json. None of the package-lock.json are from production code.

TBH, better we should write a GitHub Actions that do this job in an automated way. I always worry about our package-lock.json pointing to a registry outside of NPMJS.

@compulim compulim merged commit f581c7b into microsoft:main Sep 20, 2021
@compulim compulim deleted the bump-4.14.2-0 branch September 20, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants