Fix auto-scroll should not pause on invisible activities #3945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
When we compute when to pause the scroll, we based on the
offsetTop
of "last acknowledged activity" (LAA). When the end-user send a message, the LAA will be that message.If the LAA is an invisible activity, such as post back, message back, or event activity, we will not able to get the
offsetTop
because the LAA is not rendered.This fix is to compute the
offsetTop
based on the "first visible activity after the LAA", instead of LAA itself.Design
Specific Changes
scroller
callback to find out "first visible activity after the LAA" and use it for all computationsCHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)