-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Speech SDK 1.15.1 to support sovereign clouds #3694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
February 2, 2021 01:28
compulim
changed the title
Bump Speech SDK 1.15.0 to support sovereign clouds
Bump Speech SDK 1.15.1 to support sovereign clouds
Feb 9, 2021
corinagum
reviewed
Feb 9, 2021
corinagum
reviewed
Feb 9, 2021
corinagum
reviewed
Feb 9, 2021
corinagum
reviewed
Feb 9, 2021
corinagum
reviewed
Feb 9, 2021
corinagum
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending a few comments.
Co-authored-by: Corina <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
DIRECT_LINE_SPEECH.md
for instructionsFixed
Changed
[email protected]
[email protected]
Description
Bump Speech SDK to 1.15.0 to add sovereign cloud support and fixes several issues.
Design
Speech SDK 1.15.0 uses ES Promise interface, instead of a Promise-like interface ported from C#. We updated our test harness to support ES Promise.
We also added sovereign clouds support for Direct Line Speech. The
fetchCredentials
option passed toDirectLineSpeechSDK.createAdapters()
call should returndirectLineSpeechHostname
, instead ofregion
. For example:This change is outlined in the updated
DIRECT_LINE_SPEECH.md
.There are few tracking issues open due to bugs in 1.15.0: #3692 and #3693.
One of the issue requires us to hardcode the audio output format. We will check if the output format is wrong: if SDK pass us the output format of MP3, it must be wrong, because MP3 is not a streamable format and cannot be used in Direct Line Speech. Then we hardcode it with RIFF 16kHz instead.
One potential risk: in the future, if the service decided to send us 44.1kHz (or any other values) instead. This version of Web Chat will still use the hardcoded value 16kHz.
I am not foreseeing the service will update to 44.1kHz sooner than the SDK resolving the issue and Web Chat bumping the SDK. So, IMO, the risk is small.
Specific Changes
[email protected]
[email protected]
, changes can be found here[email protected]
forpeerDependencies
AudioConfig
to newer interface by 1.15.0cris.ai
tocustomvoice.speech.microsoft.com
AudioContext
was vendor-prefixed in SafariCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)CSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)