Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carousels' improper aria-roledescription #3599

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Nov 10, 2020

Fixes #3537

Changelog Entry

Description

Fix roles in carousels

Specific Changes

  • Adds role to activity message bubble in carousels
  • Fixes incorrect role for <li> (grouplistitem)
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum merged commit ab8b244 into microsoft:master Nov 11, 2020
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issue : Ensure aria-roledescription is only used on elements with an implicit or explicit role
2 participants