Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Samples
[email protected]
in06.recomposing-ui/c.smart-display
, by @compulim, in PR #3458Description
[email protected]
is causing issues in our CD pipeline because the way it resolveiconv-lite
and Webpack is giving warning that would trigger an error in CD pipeline. See andris9/encoding#18.Excerpt of the problematic code:
And it caused an error:
Design
Bumped from
encoding@^0.1.11
(actual0.1.12
) to[email protected]
.Specific Changes
samples/06.recomposing-ui/c.smart-display/package-lock.json
to use[email protected]
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)