Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package-lock.json in samples to resolve p-defer as peer dependency #3457

Merged
merged 8 commits into from
Sep 8, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 8, 2020

Changelog Entry

Samples

  • Update create-react-app-based samples to resolve p-defer as peer dependency, by @compulim, in PR #3457

Description

Some samples were failed to build because their package-lock.json resolve p-defer not as peer dependency.

Design

Some samples did not resolve p-defer correctly.

Specific Changes

  • Modify samples/**/package-lock.json to make sure p-defer are resolved as peer dependency of p-defer-es5
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim merged commit 53f160a into master Sep 8, 2020
@compulim compulim deleted the fix-samples branch September 8, 2020 22:46
@compulim compulim mentioned this pull request Sep 9, 2020
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants