Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3247 Add activity ID to useObserveScrollPosition and useScrollTo hooks #3372

Merged
merged 8 commits into from
Aug 5, 2020
Merged

Fix #3247 Add activity ID to useObserveScrollPosition and useScrollTo hooks #3372

merged 8 commits into from
Aug 5, 2020

Conversation

compulim
Copy link
Contributor

Fixes #3247.

Changelog Entry

Added

  • Resolves #3247. Support activity ID on useObserveScrollPosition and useScrollTo hook, by @compulim, in PR #XXX

Description

Added activityID to useObserveScrollPosition and useScrollTo hooks.

This will enable developers to programmatically scroll an activity into view.

Specific Changes

  • Updated useObserveScrollPosition hook to callback activityID
  • Updated useScrollTo hook to support activityID
    • If both activityID and scrollTop are specified, we will take scrollTop as it has better precision
  • Testing Added

@compulim compulim force-pushed the fix-3247-scroll-to-activity branch from fd16b21 to 2d47d2b Compare August 2, 2020 03:28
@compulim compulim force-pushed the fix-3247-scroll-to-activity branch from 8013976 to d8c17db Compare August 3, 2020 19:38
tonyanziano
tonyanziano approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cwhitten cwhitten merged commit 906de77 into microsoft:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OC: Scroll to message by ID (Aug 1)
3 participants
@compulim @tonyanziano @cwhitten