-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert typed emoticons into Emoji in the TextBox #3303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about implementation and another that's possibly just my own lack of understanding about hooks.
); | ||
|
||
return [value, setEmoji]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add a sample on how to customize the emoji set.
- Did you test pressing CTRL + Z after an emoticon is replaced with emoji? Can you add a test?
- CTRL + Z may not work, but it should not break.
- Please add a test for pasting text via CTRL + V. And set an expectation.
- Expectations means: pasted text will have emoticons converted, or pasted text will not have emoticons converted
- Please paste a text with 2+ emoticons, then append
:)
after it
- Please add a test for typing the following texts and set an expectation.
function enabled(): boolean { return true; }
- If the expectation is to converted this to emoji, please make sure there is a way the user can send this text without the emoji
FYI, some tests can only run under WebDriver but not Chrome because CTRL + V/Z cannot be emulated using JS.
#3249 (Feature incomplete)
Changelog Entry
Description
:)
) into emoji (😀) while typing on the fly.styleOptions
styleOptions
Specific Changes
emojiAutocorrect
totrue
instyleOptions
, emoticon typed ins SendBox will be converted to emoji on the flyemojiList
in style options allows customers to assign custom map./([:<()\\|\/3DPpoO0-]{2,3})/gim
Example styleOptions to enable custom emoji:
Data
Emoji conversion behavior comparison by app:
:)
:)
emoji:-)
)(:
:)
emojiNote on Assistive Technology behavior when Speak Typed Words is enabled:
File issue: nvaccess/nvda#11372