Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ENTER/SPACEBAR on card with tapAction #3197

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fix ENTER/SPACEBAR on card with tapAction #3197

merged 2 commits into from
Jun 3, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jun 3, 2020 •
edited
Loading

Fixes #3196.

Changelog Entry

  • Fixed #3196. Cards with tapAction should be executable by ENTER or SPACEBAR key, by @compulim in PR #3197

Description

tapAction on receipt card cannot be executed using keyboard.

Specific Changes

  • Added onKeyPress handler for <AdaptiveCardRenderer>, in addition to existing onClick handler
  • Moved /__tests__/html/serve.json to /serve-test.json
  • Fixed NUnitTestReporter error when no tests were run
  • Fixed <AdaptiveCardRenderer> and <ErrorBox> for not showing up errors properly
  • Fixed runHook may keep running hook indefinitely, if the hook errored out while running
  • Added "finish key" to assist running test with sendKeys et al. locally in a browser
  • Testing Added

@compulim compulim assigned compulim and unassigned compulim Jun 3, 2020
@compulim compulim marked this pull request as ready for review June 3, 2020 17:40
@corinagum corinagum merged commit 6c0862d into microsoft:master Jun 3, 2020
@compulim compulim mentioned this pull request Jun 10, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Accessibility] Card with tapAction cannot be executed thru ENTER/SPACEBAR
3 participants
@compulim @tdurnford @corinagum