Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version is not showing up in Direct Line Speech adapter #2706

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Fix version is not showing up in Direct Line Speech adapter #2706

merged 1 commit into from
Dec 11, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 11, 2019 •
edited
Loading

Description

Fix build script problem that version is not showing up when using Direct Line Speech adapter.

Specific Changes

  • Update package/directlinespeech/.babelrc to use npm_package_version (lowercase)
  • Testing Added
    • No tests were added for build scripts

@compulim compulim mentioned this pull request Dec 11, 2019
Closed
73 tasks
@corinagum corinagum merged commit 7d7a172 into microsoft:master Dec 11, 2019
@compulim compulim deleted the fix-dlspeech-version branch December 11, 2019 17:45
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compulim @corinagum