Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2658 Fix rendering of markdown images in IE11 #2659

Merged
merged 7 commits into from
Dec 3, 2019
Merged

#2658 Fix rendering of markdown images in IE11 #2659

merged 7 commits into from
Dec 3, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Dec 3, 2019 •
edited
Loading

Fixes #2658

Changelog Entry

Description

Before (IE11):
image

After (IE11):
image

Specific Changes

  • Testing Added

@coveralls
Copy link

coveralls commented Dec 3, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 63.696% when pulling 6938257 on corinagum:2658 into 08563a9 on microsoft:master.

compulim
compulim approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our MockBot receipt card have very similar problem. Since this is scoped to Markdown, it won't fix it.

Let's fix this one first and we add a new issue to verify all activities are handling "large" image in IE11 correctly.

packages/component/src/Styles/StyleSet/TextContent.js Outdated Show resolved Hide resolved
@corinagum corinagum mentioned this pull request Dec 3, 2019
Open
@corinagum
Copy link
Contributor Author

@compulim I added it to our MockBot update issue: #2657

@corinagum corinagum merged commit 0fcd7fe into microsoft:master Dec 3, 2019
This was referenced Dec 5, 2019
Merged
Closed
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Pre-release: Need Manual Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE11 does not respect max-width of markdown images
3 participants
@corinagum @coveralls @compulim