Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability #2648

Merged
merged 8 commits into from
Dec 2, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 2, 2019

Changelog Entry

  • Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability for Adaptive Cards, by @compulim, in PR #2648

Description

Today, we support UI recomposition, but not with Adaptive Cards. This is because we only expose a minimal <Composer> but not a full version which include Adaptive Cards support.

This PR will add UI composability for activities with Adaptive Cards. This is required for our "Smart Display" sample, which will be submitted later.

Goal: we will add a new <Composer> with enhancements specific for Adaptive Cards.

Specific Changes

  • Add internal AdaptiveCardsComposer and AdaptiveCardsContext, which store Adaptive Cards specific content
  • When loading a full-bundle
    • Enhance Composer with FullComposer, which enhance by adding Adaptive Cards specific content, and load additional style set dedicated for Adaptive Cards
    • Enhance createStyleSet with createFullStyleSet, which enhance by adding Adaptive Cards specific styles
  • Propagate defaultProps and propTypes from minimal Composer and BasicWebChat
  • Default renderMarkdown to undefined instead of text => text

  • Testing Added

@compulim compulim changed the title Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability. Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability Dec 2, 2019
@compulim compulim mentioned this pull request Dec 2, 2019
3 tasks
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 63.679% when pulling d415aa0 on compulim:feat-adaptivecards-context into 5b2e0c2 on microsoft:master.

@compulim compulim merged commit 95ab4e6 into microsoft:master Dec 2, 2019
@compulim compulim deleted the feat-adaptivecards-context branch December 2, 2019 22:54
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants