-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability #2648
Merged
compulim
merged 8 commits into
microsoft:master
from
compulim:feat-adaptivecards-context
Dec 2, 2019
Merged
Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability #2648
compulim
merged 8 commits into
microsoft:master
from
compulim:feat-adaptivecards-context
Dec 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
December 2, 2019 13:53
compulim
changed the title
Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability.
Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability
Dec 2, 2019
tdurnford
reviewed
Dec 2, 2019
tdurnford
reviewed
Dec 2, 2019
tdurnford
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
corinagum
reviewed
Dec 2, 2019
Co-Authored-By: TJ Durnford <[email protected]>
…lim/BotFramework-WebChat into feat-adaptivecards-context
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
AdaptiveCardsComposer
andAdaptiveCardsContext
for composability for Adaptive Cards, by @compulim, in PR #2648Description
Today, we support UI recomposition, but not with Adaptive Cards. This is because we only expose a minimal
<Composer>
but not a full version which include Adaptive Cards support.This PR will add UI composability for activities with Adaptive Cards. This is required for our "Smart Display" sample, which will be submitted later.
Goal: we will add a new
<Composer>
with enhancements specific for Adaptive Cards.Specific Changes
AdaptiveCardsComposer
andAdaptiveCardsContext
, which store Adaptive Cards specific contentComposer
withFullComposer
, which enhance by adding Adaptive Cards specific content, and load additional style set dedicated for Adaptive CardscreateStyleSet
withcreateFullStyleSet
, which enhance by adding Adaptive Cards specific stylesdefaultProps
andpropTypes
from minimalComposer
andBasicWebChat
renderMarkdown
toundefined
instead oftext => text