Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React Hooks for customization (part 15) #2644

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Add React Hooks for customization (part 15) #2644

merged 4 commits into from
Dec 3, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 29, 2019 •
edited
Loading

Related to #2539

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim, in the following PRs:
    • PR #2644: Added internal/useWebChatUIContext for cleaner code

Description

Cleaning up some code by adding a new useWebChatUIContext. This hook is for internal use only.

Specific Changes

  • Added component/src/hooks/useWebChatUIContext.js
    • Updated other hooks that call useContext(WebChatUIContext) to call useWebChatUIContext instead
  • Testing Added
    • No tests added because it should be covered by other tests

corinagum
corinagum approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better :) Approved pending single comment

@compulim compulim force-pushed the feat-redux-hooks-15 branch from 8200a7c to 1706406 Compare December 3, 2019 03:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 63.696% when pulling 1706406 on compulim:feat-redux-hooks-15 into e4c7e20 on microsoft:master.

@compulim compulim merged commit ff726de into microsoft:master Dec 3, 2019
@compulim compulim deleted the feat-redux-hooks-15 branch December 3, 2019 05:33
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks
3 participants
@compulim @coveralls @corinagum