Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move class components to React Hooks #2322

Merged
merged 47 commits into from
Aug 22, 2019
Merged

Move class components to React Hooks #2322

merged 47 commits into from
Aug 22, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Aug 15, 2019 •
edited
Loading

Fix #2322
Fix #1818

Changelog Entry

Description

Please see list below for which components have been 'Hooked'. Components with a PR/issue associated with it are either already Hooked, or are being tracked by that issue.

Specific Changes

  • Move to React Hooks
  • add npm run start:playground script
  • add npm run start:docker script

Previously class components:

Component name Legacy lifecycle Hooked
AdaptiveCardAttachments ✔️
AnimationCardAttachments ✔️
CommonCard ✔️
HeroCardAttachment ✔️
OAuthCardAttachment ✔️
ReceiptCardAttachment ✔️
ThumbnailCardAttachment ✔️
FullReactWebChat #2308
BasicWebChat ✔️ #2345
Composer ✔️ #2310
Dictation ✔️
ConnectivityStatus ✔️
UploadButton ✔️
CroppedImage ✔️
RelativeTime ✔️ ✔️
Timer ✔️ #2313
Box ✔️
App.js (Playground) ✔️
JSONDebugView ✔️
  • Testing Added

@coveralls
Copy link

coveralls commented Aug 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 66.388% when pulling 7493ae7 on corinagum:fix-1818 into eb6aa67 on microsoft:master.

@corinagum corinagum marked this pull request as ready for review August 22, 2019 17:22
@corinagum corinagum requested a review from tonyanziano as a code owner August 22, 2019 17:22
@corinagum corinagum changed the title DRAFT Fix 1818 Move class components to React Hooks Aug 22, 2019
@corinagum corinagum mentioned this pull request Aug 22, 2019
Closed
compulim
compulim approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited to get this in!

packages/bundle/src/adaptiveCards/Attachment/AnimationCardAttachment.js Outdated Show resolved Hide resolved
packages/bundle/src/adaptiveCards/Attachment/CommonCard.js Show resolved Hide resolved
packages/bundle/src/adaptiveCards/Attachment/HeroCardAttachment.js Show resolved Hide resolved
packages/bundle/src/adaptiveCards/Attachment/OAuthCardAttachment.js Outdated Show resolved Hide resolved
packages/bundle/src/adaptiveCards/Attachment/HeroCardAttachment.js Outdated Show resolved Hide resolved
packages/bundle/src/adaptiveCards/Attachment/ThumbnailCardAttachment.js Outdated Show resolved Hide resolved
packages/component/src/SendBox/ConnectivityStatus.js Show resolved Hide resolved
packages/playground/src/DebugAdaptiveCardAttachment.js Outdated Show resolved Hide resolved
packages/component/src/Utils/RelativeTime.js Outdated Show resolved Hide resolved
packages/component/src/SendBox/ConnectivityStatus.js Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 19d25b7 into microsoft:master Aug 22, 2019
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to functional components with React Hooks
3 participants
@corinagum @coveralls @compulim