Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Customize Web Chat with Reaction Buttons Sample #2239

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Updated Customize Web Chat with Reaction Buttons Sample #2239

merged 4 commits into from
Jul 30, 2019

Conversation

tdurnford
Copy link
Contributor

@tdurnford tdurnford commented Jul 30, 2019 •
edited
Loading

Fixes #2229

Changelog Entry

Customize Web Chat with Reaction Buttons. Updated reaction handlers to send messageReaction activities, by @tdurnford in #2239

Description

Updated handleDownvoteButton and handleUpvoteButton methods to post a messageReaction activity instead of a message activity. Also updated Mock Bot to handle messageReaction activities.

  • Testing Added

@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 64.984% when pulling 1b38407 on tdurnford:2229 into f5b8db5 on microsoft:master.

@corinagum
Copy link
Contributor

LGTM.

@compulim?

@corinagum corinagum merged commit 607ba96 into microsoft:master Jul 30, 2019
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sample] The reaction buttons sample should be updated to use the SDK's reaction handlers
4 participants
@tdurnford @coveralls @corinagum @compulim