Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chat send history sample #1678

Merged
merged 4 commits into from
Feb 4, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 31, 2019

closes #1091

Added

@coveralls
Copy link

coveralls commented Jan 31, 2019

Pull Request Test Coverage Report for Build 911

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 52.542%

Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 889: 0.0%
Covered Lines: 882
Relevant Lines: 1526

💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n added 4.3 and removed 4.4 labels Jan 31, 2019
@cwhitten
Copy link
Member

cwhitten commented Feb 1, 2019

I'm unclear why this isn't provided by the component out of the box!

@a-b-r-o-w-n
Copy link
Contributor Author

@cwhitten one thing I can think of in opposition to adding this to the bundle is concerns over security / managing the session state. Would it be by user / conversation / bot / something else? IMO this is better suited as a custom add on that suits the customer's need. Also, while this feature is helpful for testing, I am not convinced that it is useful for the majority of bot interactions.

@a-b-r-o-w-n a-b-r-o-w-n merged commit ba2a382 into microsoft:master Feb 4, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the chat-history-sample branch February 4, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Up/down arrow for send history
3 participants