Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCAG 2.1.1: Elements that have scrollable content should be accessible by keyboard (.webchat__carousel-filmstrip.webchat__carousel-filmstrip--top-callout.react-film__filmstrip) #3814

Closed
corinagum opened this issue Mar 24, 2021 · 0 comments · Fixed by #3841
Closed

WCAG 2.1.1: Elements that have scrollable content should be accessible by keyboard (.webchat__carousel-filmstrip.webchat__carousel-filmstrip--top-callout.react-film__filmstrip) #3814

corinagum opened this issue Mar 24, 2021 · 0 comments · Fixed by #3841
Assignees
@corinagum
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. p0 Must Fix. Release-blocker p1 Painful if we don't fix, won't block releasing
Milestone
R14

Comments

@corinagum
Copy link
Contributor

Issue

Elements that have scrollable content should be accessible by keyboard (scrollable-region-focusable)

Target application

React App

Element path

.webchat__basic-transcript__activity--from-bot.webchat__basic-transcript__activity.webchat__basic-transcript__activity--acknowledged:nth-child(78) > .webchat__basic-transcript__activity-box > .webchat__carousel-layout.webchat--css-gdief-12j4dva.webchat--css-gdief-1xupiz0 > .react-film__main > .webchat__carousel-filmstrip.webchat__carousel-filmstrip--top-callout.react-film__filmstrip`

Description:

Carousels are navigable but contents are not, and are not described

Repro:

  • layout double
  • layout carousel
  • slow
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. area-accessibility p0 Must Fix. Release-blocker p1 Painful if we don't fix, won't block releasing labels Mar 24, 2021
@corinagum corinagum added this to the R14 milestone Apr 6, 2021
@corinagum corinagum self-assigned this Apr 6, 2021
corinagum added a commit to corinagum/BotFramework-WebChat that referenced this issue Apr 9, 2021
@corinagum
microsoft#3814 Add tabindex and focus indicator to carousel children
5d6c134
@corinagum corinagum mentioned this issue Apr 9, 2021
Merged
11 tasks
corinagum added a commit to corinagum/BotFramework-WebChat that referenced this issue Apr 13, 2021
@corinagum
microsoft#3814 Add tabindex and focus indicator to carousel children
9b2a963
corinagum added a commit that referenced this issue Apr 16, 2021
@corinagum
Allow carousel's scrollable content to be tab-able with visual focus (#…
0cfa100 
…3841)

* Add eslint comments

* Test cleanup

* #3814 Add tabindex and focus indicator to carousel children

* Add tests

* Update CHANGELOG.md

* Update info on transcript visual focus

* Update CODEOWNERS

* Update tests

* Create CarouselFilmStripAttachment component

* Fix test

* PR review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. p0 Must Fix. Release-blocker p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
R14
Development

Successfully merging a pull request may close this issue.

Allow carousel's scrollable content to be tab-able with visual focus corinagum/BotFramework-WebChat
1 participant
@corinagum