Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: avatar comprehensive demo is not working #3261

Closed
compulim opened this issue Jun 17, 2020 · 1 comment
Closed

Sample: avatar comprehensive demo is not working #3261

compulim opened this issue Jun 17, 2020 · 1 comment
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior. community-help-wanted This is a good issue for a contributor to take on and submit a solution Good first bug

Comments

@compulim
Copy link
Contributor

Screenshots

image

Version

master

Describe the bug

Navigate to https://microsoft.github.io/BotFramework-WebChat/05.custom-components/k.per-message-avatar/comprehensive.html. The page throw a JavaScript error.

Typo at https://github.com/microsoft/BotFramework-WebChat/blob/master/samples/05.custom-components/k.per-message-avatar/comprehensive.html#L125.

- <script type="text/babel" data-presets="es2015.react,stage-3">
+ <script type="text/babel" data-presets="es2015,react,stage-3">

Steps to reproduce

  1. Go to https://microsoft.github.io/BotFramework-WebChat/05.custom-components/k.per-message-avatar/comprehensive.html

Expected behavior

It should show the demo properly.

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. community-help-wanted This is a good issue for a contributor to take on and submit a solution Good first bug labels Jun 17, 2020
corinagum pushed a commit that referenced this issue Jun 18, 2020
@utkarsh2827
Fixed Issue: #3261 (#3262)
1bb780c 
Corrected the typo as mentioned in the bug.
@corinagum
Copy link
Contributor

Fixed in #3262

@compulim compulim self-assigned this Jun 24, 2020
@compulim compulim added the R10 label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior. community-help-wanted This is a good issue for a contributor to take on and submit a solution Good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@compulim @corinagum