Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample "04.api/h.clear-after-idle" is causing build break #2828

Closed
compulim opened this issue Jan 18, 2020 · 0 comments · Fixed by #3376
Closed

Sample "04.api/h.clear-after-idle" is causing build break #2828

compulim opened this issue Jan 18, 2020 · 0 comments · Fixed by #3376
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. community-help-wanted This is a good issue for a contributor to take on and submit a solution

Comments

@compulim
Copy link
Contributor

Screenshots

image

Version

master

Describe the bug

  1. The initConversation and useTimer to depending on each other, which will cause build to fail
  2. setTimeRemaining need to be added to deps list of initConversation

Steps to reproduce

  1. Clone the repository
  2. Under samples/04.api/h.clear-after-idle, run npm run build

Expected behavior

Build should success.

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jan 18, 2020
@cwhitten cwhitten added the R9 label Mar 9, 2020
@corinagum corinagum removed the Pending label Apr 3, 2020
@cwhitten cwhitten assigned compulim and unassigned tdurnford Apr 7, 2020
@cwhitten cwhitten added R10 and removed R9 labels Apr 9, 2020
@compulim compulim added community-help-wanted This is a good issue for a contributor to take on and submit a solution backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed R10 labels Jul 13, 2020
@compulim compulim mentioned this issue Aug 3, 2020
Merged
2 tasks
compulim added a commit that referenced this issue Aug 3, 2020
@compulim
Fix #2828 Clear idle sample (#3376)
0d8d47f 
* Clean up

* Update to 4.9.2

* Fix ESLint

* Add entry

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. community-help-wanted This is a good issue for a contributor to take on and submit a solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2828 Clear idle sample compulim/BotFramework-WebChat
4 participants
@cwhitten @compulim @corinagum @tdurnford